EduardoKrausME / moodle-mod_supervideo

8 stars 5 forks source link

postgres support is a requirement for plugins db approval #8

Closed danmarsden closed 1 year ago

danmarsden commented 1 year ago

I'm guessing (but didn't test) this query will fail in postgres: https://github.com/EduardoKrausME/moodle-mod_supervideo/blob/master/classes/report/supervideo_view.php#L318-L332

but there could be other queries in your plugin that don't work - it would be preferable that you test the plugin on a postgres install yourself (rather than relying on the plugin review team being the first to do this.)

eduardokraus commented 1 year ago

Fixed and tested with: https://extendsclass.com/postgresql-online.html

danmarsden commented 1 year ago

can't see any changes to that script in github, but maybe you haven't pushed your changes yet? - I'd expect Postgres to complain about the group by statement not including sv.cm_id

eduardokraus commented 1 year ago

only https://github.com/EduardoKrausME/moodle-mod_supervideo/blob/master/classes/report/supervideo_view.php#L330