search

EduardoKrausME / moodle-mod_supervideo

8 stars 5 forks source link

recordset used but not closed #9

Closed danmarsden closed 1 year ago

danmarsden commented 1 year ago

https://github.com/EduardoKrausME/moodle-mod_supervideo/blob/master/classes/report/supervideo_view.php#L355

simplest option is to just change this to a get_records_sql() call instead of a get_recordset_sql() call - not closing recordsets can cause all sorts of grief that is very hard to trace! :-)

eduardokraus commented 1 year ago

The query_db function is an override of the table_sql class, which I had to bring to this class because it needed some changes.

The original function uses get_recordset_sql.

danmarsden commented 1 year ago

Whoops obviously not looking close enough while doing that quick review! Yep you're right, I missed this was extending the flexible table core stuff.