Total, tax and delivery are not used

EduardoZepeda / django-payments-mercadopago

A mercadopago payment gateway backend for django-payments.

MIT License

13 stars 1 forks source link

Total, tax and delivery are not used #2

Open WhyNotHugo opened 3 years ago

WhyNotHugo commented 3 years ago

There's a few values being calculated, but they don't seem to be used and are not being sent:

https://github.com/EduardoZepeda/django-payments-mercadopago/blob/d4e7814a4a8fe51ff0f024ff754531337281f9da/payments_mercadopago/__init__.py#L67-L69

I don't think the API has any fields for these values, so I think it's best to delete them...?

EduardoZepeda commented 2 years ago

I checked and you were completely right, those values aren't being used anywhere, I already delete them and I also added some type hints, hope you can check them. By the way, I just looked the (now closed) pull requests. I was very busy but I managed to write some code these days. I hope you can give it a look whenever you're free.