search

Edubits / Zway-MQTT

Publishes the status of devices to a MQTT topic and is able to set values based on subscribed topics.
Apache License 2.0
29 stars 16 forks source link

add stop for roller shutter devices #18

Closed vectah0 closed 7 years ago

Edubits commented 7 years ago

Thanks for the PR @vectah0! I see you've added the command for stopping, but it seems there are other commands for shutter/blinds as well. We could add those as well. But maybe a better solution is to check if the payload is numeric and if not always call device.performCommand for it. Then we can prevent having to exclude all commands. What do you think about that?

vectah0 commented 7 years ago

as far as I know the commands for shutters are ON(DOWN/UP), STOP, OFF(DOWN/UP) and SWITCH_MULTILEVEL for taking control of the shutters using a slider for example, please correct me if I'm wrong. Which other commands did you mean?

Edubits commented 7 years ago

The commands supported by Zway for shutters/blinds can be found at https://github.com/Z-Wave-Me/home-automation/blob/a3ad2baa7f8453f3df6adead9896498926eb8833/modules/ZWave/index.js#L2599 You mentioned the most important, but there are a few more apparently.