Closed magnemo closed 11 months ago
A test on dev is not working. It gets the error: "SyntaxError: Cannot use 'import.meta' outside a module"... Not our test, and the code is working just fine outside the test file. It's just because the test file isn't considered by Node to be a module. As it isn't our test, we don't know how it is supposed to run and how then to modify it to work on short notice.
A test on dev is not working. It gets the error: "SyntaxError: Cannot use 'import.meta' outside a module"... Not our test, and the code is working just fine outside the test file. It's just because the test file isn't considered by Node to be a module. As it isn't our test, we don't know how it is supposed to run and how then to modify it to work on short notice.
The tests should have passed when they were pushed to dev originally, hence the tests not passing now does not make sense, unless conflict has been introduced. I think we should attempt to fix the tests rather than just ignore them, as this defeats the purpose of tests.... Otherwise we should discuss this with the integration team before merging imo.
Approved, and after a small hotfix session, we got it to work.
Description
This pull request contains these completed PBI's:
[Web Create] As a content creator, I want to be able to put an exercise on the section I'm creating [Web Create] As a content creator, I want to be able to put a lecture on the section I'm creating [Web Edit] As a content creator, I want to be able to edit or delete sections, lectures or exercises of the courses I haven't published yet
Changes
All changes have been made in the section edit page (excluding bug fixes).
General changes Translated to Portuguese. A limit of having max 10 exercises + lectures has been implemented.
Exercises
Lectures
Bug fixes: Courses (Create/Update) now sends a number value for difficulty. Course (Create/Update) now sends a translated response of the categories to the back end.
Checklist
Notes for Reviewers
The backend used for this pull requist is "VirtualTurtor-Merge". This code needs access to mongoDB to function.
Linting gives a lot of errors, we fixed a lot of the existing errors linting gave, but the rest are non trivial errors that don't inhibit the code and are therefore not a priority right no