Educado-App / educado-frontend

The repository for the educado content creation web platform.
https://app.educado.com
GNU General Public License v3.0
0 stars 4 forks source link

Onboarding - Content Creator Application: Creation, Viewing, Rejection, Approval #53

Closed Adachigaming closed 10 months ago

Adachigaming commented 10 months ago

Description

This PR is mostly about the creation, viewing, rejection, and approval of freelance Content Creators, with some additional design changes.

Changes

New Features

New Design

Related Issues

Checklist

Screenshots (if applicable)

application admin single

If mobile/frontend pull request, what version of the backend is it stable, and running on?

Runs on the "Onboarding-devMerge" backend, commit id: 146ad37

Notes for Reviewers

The backend has an active PR that this version can run on.

Jatewo commented 10 months ago

Notes for Reviewers

The backend has an active PR that this version can run on. Additionally, we take no blame in the cypress tests failing, as the certificates do not even load on dev

It absolutely works. You have to run it with backend cert-get-user/cert-get-user-merge and with the cert-certificates-info in the certificate service. It is in the process of being merged into dev and staging. Furthermore, please note that failed tests are always your responsibility - not something you can just ignore / pass the blame on.

Edit: Backend can now use dev

Adachigaming commented 10 months ago

It absolutely works. You have to run it with backend cert-get-user/cert-get-user-merge and with the cert-certificates-info in the certificate service. It is in the process of being merged into dev and staging. Furthermore, please note that failed tests are always your responsibility - not something you can just ignore / pass the blame on.

Yes, I was not aware of the fact that the certificates were on a different repository entirely. Still, that does not excuse the dismissive way the note was written, and for that I apologize.

Jatewo commented 10 months ago

You can make a new PR from this branch and make sure you have addressed all requested changes, then rerequest reviews. I do not want to see another merge without approvals.