Issue #195 highlighted that in some situations, the log in notification that appers after logging in would appear at other times as well.
Changes
feat(CourseScreen): login notification now shows if 'loggedIn' item from AsyncStorage is present. After showing the notification, the 'loggedIn' item is removed
feat(LoginForm): 'loggedIn' is added to AsyncStorage when logging in
feat(Login): 'loggedIn' is added to AsyncStorage when logging in automatically
Related Issues
Issue #195.
Checklist
[X] Code has been tested locally and passes all relevant tests.
[X] Documentation has been updated to reflect the changes, if applicable.
[X] Code follows the established coding style and guidelines of the project.
[X] All new and existing tests related to the changes have passed.
[X] Any necessary dependencies or new packages have been properly documented.
[X] Pull request title and description are clear and descriptive.
[X] Reviewers have been assigned to the pull request.
[X] Any potential security implications have been considered and addressed.
[X] Performance impact of the changes has been evaluated, if relevant.
Screenshots (if applicable)
None.
If mobile/frontend pull request, what version of the backend is it stable, and running on?
Right now this is done using AsyncStorage. A better solution would be to use for example a global state management solution, but will not be done given the time constraints.
Description
Issue #195 highlighted that in some situations, the log in notification that appers after logging in would appear at other times as well.
Changes
feat(CourseScreen): login notification now shows if 'loggedIn' item from AsyncStorage is present. After showing the notification, the 'loggedIn' item is removed feat(LoginForm): 'loggedIn' is added to AsyncStorage when logging in feat(Login): 'loggedIn' is added to AsyncStorage when logging in automatically
Related Issues
Issue #195.
Checklist
Screenshots (if applicable)
None.
If mobile/frontend pull request, what version of the backend is it stable, and running on?
Branch: dev
Commit id: https://github.com/Educado-App/educado-backend/commit/65bffdbfb1a9c839a250eeee312e0c35c2d574e1
Notes for Reviewers
Right now this is done using AsyncStorage. A better solution would be to use for example a global state management solution, but will not be done given the time constraints.