Gamified fix logic with isComplete issue #199 2.0

loui981c commented 11 months ago

Description

Addressing the problem where only exercise components inside the swiper had isComplete set to true has been resolved. Now, all components are updated, and the swiper starts at the first incomplete component, if any, instead of the start. Additionally, there is a refactoring of the points logic, but the underlying logic remains unchanged.

Changes

The changes are related to issue https://github.com/Educado-App/educado-mobile/issues/199

Related Issues

Issue #199

Checklist

[X] Code has been tested locally and passes all relevant tests.
[X] Documentation has been updated to reflect the changes, if applicable.
[X] Code follows the established coding style and guidelines of the project.
[X] All new and existing tests related to the changes have passed.
[X] Any necessary dependencies or new packages have been properly documented.
[X] Pull request title and description are clear and descriptive.
[X] Reviewers have been assigned to the pull request.
[X] Any potential security implications have been considered and addressed.
[X] Performance impact of the changes has been evaluated, if relevant.

If mobile/frontend pull request, what version of the backend is it stable, and running on?

Branch: gamified_dev_copy_nov27

Commit id: de67564

Notes for Reviewers

I have commented out some of the tests since the functions do not exist and they can't be found in the current dev branch. Please test with a new user and the third section of the course Finance

benceisonline commented 11 months ago

all tests pass and everything works on simulator with the corresponding backend 🥳 🥳 🥳

benceisonline commented 11 months ago

I just tried to run it with backend specified. With the user I was already logged in with, i could not se any lectures or exercises, they just load forever. I logged out and tried to log in again to see if that was the issue. I was unable to log in with an existing user or with a new user. These things needs to be fixed before this PR should be approved.

@Donhusum Sounds like you are not connected to the db, did you make sure to update the api and userApi files with your own IP? I have just tested everything again to make sure that I have not overlooked anything, and everything works fine for me.

Donhusum commented 11 months ago

I just tried to run it with backend specified. With the user I was already logged in with, i could not se any lectures or exercises, they just load forever. I logged out and tried to log in again to see if that was the issue. I was unable to log in with an existing user or with a new user. These things needs to be fixed before this PR should be approved.

@Donhusum Sounds like you are not connected to the db, did you make sure to update the api and userApi files with your own IP? I have just tested everything again to make sure that I have not overlooked anything, and everything works fine for me.

I was connected to the DB. I could load and see the sections, I could create new users, and I could see the backend working as you have a console.log somwhere telling then you call for sections.

loui981c commented 11 months ago

try to unsub and sub to the course again

Donhusum commented 11 months ago

try to unsub and sub to the course again

Hard to test since I can't log in on you setup. I tried using the dev backed instead of yours. Now I can log in no problem, but the lectures and exercises are still not showing, even when I unsub and sub again.

Educado-App / educado-mobile