Complete Course animation - Githubissues

Educado-App / educado-mobile

The repository for the educado mobile education application

GNU General Public License v3.0

1 stars 3 forks source link

Complete Course animation #222

Closed benceisonline closed 10 months ago

benceisonline commented 11 months ago

Description

Course completion animation, and small fix to section animation. The matching backend should be merged first.

Changes

Mainly added files for the course completion and commented extra points out on section completion screen.

Related Issues

https://github.com/orgs/Educado-App/projects/9/views/1?pane=issue&itemId=44144208

Checklist

[x] Code has been tested locally and passes all relevant tests.
[x] Documentation has been updated to reflect the changes, if applicable.
[x] Code follows the established coding style and guidelines of the project.
[x] All new and existing tests related to the changes have passed.
[x] Any necessary dependencies or new packages have been properly documented.
[x] Pull request title and description are clear and descriptive.
[x] Reviewers have been assigned to the pull request.
[x] Any potential security implications have been considered and addressed.
[x] Performance impact of the changes has been evaluated, if relevant.

Screenshots (if applicable)

Screenshot 2023-11-28 at 14 35 47

Screenshot 2023-11-28 at 14 35 41

Screenshot 2023-11-28 at 14 35 34

Screenshot 2023-11-28 at 14 32 33

If mobile/frontend pull request, what version of the backend is it stable, and running on?

Branch: gamified_dev_copy_nov28

Commit id: 579d445

Notes for Reviewers

Some comments are relevant for future developers. Hack database to display course completion:

Go into the student doc, go to the finance course in the field courses, and set the first and second elements in the array of sections to be isCompleted = true

benceisonline commented 11 months ago

yes we know that a test is failing 🐦