Educado-App / educado-mobile

The repository for the educado mobile education application
GNU General Public License v3.0
1 stars 3 forks source link

Fixed bug 4.1 and improvement 4.2 #247

Closed MagnusHoese closed 2 days ago

magnusklundgren commented 1 month ago

Change base branch from main to dev branch

Laskiri commented 1 month ago

We need to make a staging branch as well if I remember correctly. Changes look good to me, but the linting errors need to be sorted out first😊👍 Note: For future pull requests I think it would be great if we all follow the pr template provided in resources.

magnusklundgren commented 1 month ago

Proposed change to Validation.js code quality: Replace const namePattern = /^(\p{L}+[- '])*\p{L}+$/u; and const emailPattern = /^\w+([.-]?\w+)*@\w+([.-]?\w+)*(\.\w{2,3})+$/; With if (!patterns.name.test(name)) { return '${wordForName} invĂĄlido'; // Invalid name }

The pattern is already defined in a separate file, but then copied into this file. A change in the pattern needs to be done in two different places as it is implemented now. The proposed change should eliminate duplication and follow the DRY(Don't Repeat Yourself) principle.

If you want to keep the namePattern variable, just put: const namePattern = patterns.name.

This proposed change is outside the scope for the backlogged issue, but would improve the quality of the codebase.

benceisonline commented 1 month ago

i skal merge i dev, ikke main:)

MagnusHoese commented 1 month ago

Men brother, dev er bag main

benceisonline commented 1 month ago

hvis main har noget som dev ikke har (probs hotfix), sÄ kan i lave en kopi af main og merge den kopi ind i dev inden i merger nye ting ind

MagnusHoese commented 1 month ago

Hvis du siger det

Jenspetersen99 commented 1 month ago

Er det ikke lidt overkill med 3 mennesker til at kigge en pr igennem? Troede ogsÄ magnus, havde sat en reviewer pÄ allerede?

Lowkee1g commented 1 month ago

Could you please change the base branch for this pull request from ‘dev2’ to ‘Dev’?

MBryder commented 1 month ago

Dev branch is up to date change from dev2 to dev