Closed MagnusHoese closed 2 days ago
We need to make a staging branch as well if I remember correctly. Changes look good to me, but the linting errors need to be sorted out firstđđ Note: For future pull requests I think it would be great if we all follow the pr template provided in resources.
Proposed change to Validation.js code quality:
Replace const namePattern = /^(\p{L}+[- '])*\p{L}+$/u;
and const emailPattern = /^\w+([.-]?\w+)*@\w+([.-]?\w+)*(\.\w{2,3})+$/;
With
if (!patterns.name.test(name)) { return '${wordForName} invĂĄlido'; // Invalid name }
The pattern is already defined in a separate file, but then copied into this file. A change in the pattern needs to be done in two different places as it is implemented now. The proposed change should eliminate duplication and follow the DRY(Don't Repeat Yourself) principle.
If you want to keep the namePattern
variable, just put:
const namePattern = patterns.name
.
This proposed change is outside the scope for the backlogged issue, but would improve the quality of the codebase.
i skal merge i dev, ikke main:)
Men brother, dev er bag main
hvis main har noget som dev ikke har (probs hotfix), sÄ kan i lave en kopi af main og merge den kopi ind i dev inden i merger nye ting ind
Hvis du siger det
Er det ikke lidt overkill med 3 mennesker til at kigge en pr igennem? Troede ogsÄ magnus, havde sat en reviewer pÄ allerede?
Could you please change the base branch for this pull request from âdev2â to âDevâ?
Dev branch is up to date change from dev2 to dev
Change base branch from main to dev branch