search

EducationalTestingService / factor_analyzer

A Python module to perform exploratory & confirmatory factor analyses.
GNU General Public License v2.0
235 stars 68 forks source link

Fixing bug regarding unbound `new_order` variable #98

Closed jbiggsets closed 2 years ago

jbiggsets commented 2 years ago

This is simple bug fix. The if structure is not None statement should be nested under the preceding if statement, where new_order is defined. Since it's not, users can get an error if they're using the principal method with a rotation that creates a structure matrix.

This addresses issue #96.

codecov[bot] commented 2 years ago

Codecov Report

Merging #98 (d738146) into main (94ac334) will decrease coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #98      +/-   ##
==========================================
- Coverage   94.33%   94.32%   -0.02%     
==========================================
  Files           7        7              
  Lines        1006     1004       -2     
==========================================
- Hits          949      947       -2     
  Misses         57       57
Impacted Files Coverage Δ
factor_analyzer/factor_analyzer.py 94.80% <100.00%> (-0.05%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 94ac334...d738146. Read the comment docs.