EducationalTestingService / rstfinder

Fast Discourse Parser to find latent Rhetorical STructure (RST) in text.
MIT License
121 stars 24 forks source link

update to latest version of skll #47

Closed aoifecahill closed 3 years ago

ghost commented 6 years ago

Isn't it that #46 will automatically use SKLL latest version.

desilinguist commented 4 years ago

We have already updated to SKLL v2.0 in #54 but that's not the latest version. Do we just stop there @aoifecahill @bndgyawali ?

aoifecahill commented 4 years ago

I would rather unpin the dependency or at least switch to minimum only. Setting an exact version will be a pain for downstream apps at some point in the future.

desilinguist commented 4 years ago

Yeah, I think unpinning makes a lot of sense. So that way it will work internally at ETS too where the SKLL version may be pinned in another place.