EducationalTestingService / skll

SciKit-Learn Laboratory (SKLL) makes it easy to run machine learning experiments.
http://skll.readthedocs.org
Other
551 stars 67 forks source link

Align parameters and hyperparameters with planned changes in scikit-learn #533

Closed desilinguist closed 5 years ago

desilinguist commented 5 years ago

This PR makes the following changes in anticipation of the changes that will be coming in scikit-learn v0.22 (#438). We are making them now since v2.0 is a major release and we can pack in backwards incompatible changes here rather than later:

codecov[bot] commented 5 years ago

Codecov Report

Merging #533 into master will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #533      +/-   ##
=========================================
+ Coverage    94.1%   94.1%   +<.01%     
=========================================
  Files          20      20              
  Lines        2918    2919       +1     
=========================================
+ Hits         2746    2747       +1     
  Misses        172     172
Impacted Files Coverage Δ
skll/config.py 95.12% <ø> (ø) :arrow_up:
skll/learner.py 93.67% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 114d088...0b43a0a. Read the comment docs.

desilinguist commented 5 years ago

@aoifecahill I'd really like your review for this PR as well. Thanks!