EducationalTestingService / skll

SciKit-Learn Laboratory (SKLL) makes it easy to run machine learning experiments.
http://skll.readthedocs.org
Other
551 stars 67 forks source link

Interactive Binder Tutorial #547

Closed AVajpayeeJr closed 5 years ago

AVajpayeeJr commented 5 years ago

This PR is intended to address #448. It includes the following changes -

Notes - The interactive tutorial is meant to be done in conjunction with reading the SKLL documentation

Post-review, I shall change the link to point to master repository.

codecov[bot] commented 5 years ago

Codecov Report

Merging #547 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #547   +/-   ##
=======================================
  Coverage   94.47%   94.47%           
=======================================
  Files          20       20           
  Lines        2951     2951           
=======================================
  Hits         2788     2788           
  Misses        163      163

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update aba9003...e138e85. Read the comment docs.

desilinguist commented 5 years ago

I think one comment I have is that we should create an ETS level account for binder rather than using @AVajpayeeJr 's personal account. I can take care of that as part of my review for this PR once I finish the PR I am working on.

desilinguist commented 5 years ago

I would like to make some changes to the notebook and that's much easier with a local branch rather than a branch on a fork. @AVajpayeeJr I have made a local branch containing your changes and will make another PR using that branch. So, I am going to close this PR.