EducationalTestingService / skll

SciKit-Learn Laboratory (SKLL) makes it easy to run machine learning experiments.
http://skll.readthedocs.org
Other
551 stars 67 forks source link

Preparing for SKLL v2.0 Release #580

Closed desilinguist closed 5 years ago

desilinguist commented 5 years ago

(Note: Due to the issues discovered on Windows which necessitated the integration of Azure Pipelines for regular testing, this release PR will be longer than usual. Thanks for your patience!)

Please run the following tests before approving this PR:

codecov[bot] commented 5 years ago

Codecov Report

Merging #580 into master will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #580      +/-   ##
==========================================
+ Coverage   95.02%   95.02%   +<.01%     
==========================================
  Files          20       20              
  Lines        2973     2974       +1     
==========================================
+ Hits         2825     2826       +1     
  Misses        148      148
Impacted Files Coverage Δ
skll/data/writers.py 94.38% <100%> (ø) :arrow_up:
skll/data/readers.py 90.51% <100%> (ø) :arrow_up:
skll/experiments.py 95.52% <100%> (ø) :arrow_up:
skll/logutils.py 100% <100%> (ø) :arrow_up:
skll/version.py 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e617e71...6b1e5b5. Read the comment docs.

ghost commented 5 years ago

Looks good to me thanks! I tested the conda/pip packages and ran the tests on MacOS and didn't find any issues.

I also tested them via pip/conda and ran examples, and worked fine.