search

EducationalTestingService / skll

SciKit-Learn Laboratory (SKLL) makes it easy to run machine learning experiments.
http://skll.readthedocs.org
Other
550 stars 69 forks source link

Fix Windows log/warnings issue #586

Closed mulhod closed 4 years ago

mulhod commented 4 years ago

Addresses #579.

Because of an issue with the way we were computing correlation, the log/warnings behavior was reacting differently on Windows vs *nix. So, this PR just makes the test use a different objective that wouldn't issue the same warning. Also, an issue will be made to deal with log/warnings behavior when grid_search_jobs is greater than 1 in unit tests (see #587).

codecov[bot] commented 4 years ago

Codecov Report

Merging #586 into master will increase coverage by 0.03%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #586      +/-   ##
==========================================
+ Coverage   95.02%   95.05%   +0.03%     
==========================================
  Files          20       20              
  Lines        2974     2974              
==========================================
+ Hits         2826     2827       +1     
+ Misses        148      147       -1
Impacted Files Coverage Δ
skll/learner.py 96.12% <0%> (+0.12%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6472139...8078179. Read the comment docs.

mulhod commented 4 years ago

One more review, please? @bndgyawali @jbiggsets @aoifecahill @ananyaganesh @chaomenghsuan