search

EducationalTestingService / skll

SciKit-Learn Laboratory (SKLL) makes it easy to run machine learning experiments.
http://skll.readthedocs.org
Other
551 stars 67 forks source link

min. number of examples check for the the learning_curve method #631

Closed srhrshr closed 4 years ago

srhrshr commented 4 years ago

@desilinguist , this PR closes #624 - I've added a hard minimum number of examples constraint for the learning_curve method. Let me know if this is what you had in mind.

codecov[bot] commented 4 years ago

Codecov Report

Merging #631 into main will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #631   +/-   ##
=======================================
  Coverage   95.10%   95.10%           
=======================================
  Files          27       27           
  Lines        3083     3087    +4     
=======================================
+ Hits         2932     2936    +4     
  Misses        151      151
Impacted Files Coverage Δ
skll/learner/__init__.py 96.26% <100.00%> (+0.02%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2add4bf...6ed1084. Read the comment docs.

pep8speaks commented 4 years ago

Hello @srhrshr! Thanks for updating this PR.

Line 91:28: E127 continuation line over-indented for visual indent

Comment last updated at 2020-10-28 16:20:44 UTC
desilinguist commented 4 years ago

Seems like a missing import?

desilinguist commented 4 years ago

Hmm, I am seeing a partial failure on the windows builds: