Closed srhrshr closed 4 years ago
Ran into 1 nosetests
error due to a module root issue, and the sys.path insertion commit fixes it. All good now.
Traceback (most recent call last):
File "--------------/skll/examples/make_titanic_example_data.py", line 15, in <module>
from skll.data import Reader, Writer
ModuleNotFoundError: No module named 'skll'
Retrieving boston data from servers...done
Writing training and testing files...done
Retrieving iris data from servers...done
Writing training and testing files...done
E
======================================================================
ERROR: Run all of the configuration files for the titanic example
----------------------------------------------------------------------
Traceback (most recent call last):
File "........../.pyenv/versions/3.6.9/envs/skll-0.23.2/lib/python3.6/site-packages/nose/case.py", line 198, in runTest
self.test(*self.arg)
File "...............skll/tests/test_examples.py", line 133, in test_titanic_configs
run_configuration_and_check_outputs(config_path)
File "...............skll/tests/test_examples.py", line 48, in run_configuration_and_check_outputs
results_json_path = run_configuration(config_path, local=True, quiet=True)[0]
File "...............skll/skll/experiments/__init__.py", line 570, in run_configuration
log_level=log_level)
File "...............skll/skll/config/__init__.py", line 628, in parse_config_file
train_path = locate_file(train_path, config_dir)
File "...............skll/skll/config/utils.py", line 106, in locate_file
raise IOError(errno.ENOENT, "File does not exist", path_to_check)
FileNotFoundError: [Errno 2] File does not exist: '...............skll/tests/other/titanic/train+dev' ```
Merging #632 into main will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## main #632 +/- ##
=======================================
Coverage 95.10% 95.10%
=======================================
Files 27 27
Lines 3083 3083
=======================================
Hits 2932 2932
Misses 151 151
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 3b63403...7b1dd43. Read the comment docs.
@srhrshr Thanks for the PR, by the way! It's much appreciated. I just had a couple comments about relaxing the requirement so that it includes 0.23.2
but doesn't exclude 0.23.1
.
@desilinguist , this closes #630. Will update this PR with local nose test results to double check that there aren't any regressions.