Closed RobertImbrie closed 3 years ago
Thanks for this @RobertImbrie!
Turns out that Gitlab CI for Github will not build PRs from external forks 🤦🏽(though they have been debating it for almost 2 years now!) Since this is our first external PR via a fork after migrating to Gitlab CI, I wasn't aware of this until now.
For PRs with non-code changes like this one, we can just rely on the Azure Pipelines build and merge without the Gitlab CI check. However, for PRs with code changes, we will need to figure out a workaround. Here's one possible solution:
main
. main
. Thoughts @aoifecahill @mulhod @bndgyawali ? Of course, ideally, we should automate this process using a bot or something like GitHub Actions?
Yeah, that process makes sense to me. And I agree, automating it would be ideal.
This PR closes #677.
Note: In the issue (and in other parts of the repository), it's spelled "Gitlab," which I defaulted to in order to keep things consistent. However, it's officially spelled "GitLab," with a capitalized L. We should open another issue to fix this.