EducationalTestingService / skll

SciKit-Learn Laboratory (SKLL) makes it easy to run machine learning experiments.
http://skll.readthedocs.org
Other
550 stars 69 forks source link

Rewrite docstrings for skll/data/dict_vectorizer.py #683

Closed RobertImbrie closed 3 years ago

RobertImbrie commented 3 years ago

Notes: Still no array parameters!

desilinguist commented 3 years ago

@RobertImbrie one thing you should make sure to do is to always update the main branch in your working copy by running git pull after every PR merge. Otherwise, the branches you create will be out of date (as this one is).

codecov[bot] commented 3 years ago

Codecov Report

Merging #683 (abb3a84) into main (e9d28b4) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #683   +/-   ##
=======================================
  Coverage   96.85%   96.85%           
=======================================
  Files          63       63           
  Lines        9098     9098           
=======================================
  Hits         8812     8812           
  Misses        286      286           
Impacted Files Coverage Δ
skll/data/dict_vectorizer.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e9d28b4...abb3a84. Read the comment docs.

RobertImbrie commented 3 years ago

@desilinguist My mistake! I had been pulling to the feature branch, but not to main. I'll make sure to correct that in the future!