search

EducationalTestingService / skll

SciKit-Learn Laboratory (SKLL) makes it easy to run machine learning experiments.
http://skll.readthedocs.org
Other
550 stars 69 forks source link

Allow passing of sample weights to fit() #692

Closed aoifecahill closed 3 years ago

aoifecahill commented 3 years ago

It would be nice to be able to provide a file containing sample weights for them to be passed along to the sample_weight argument of fit().

desilinguist commented 3 years ago

You mean, pass a file to train() which then passes it to sklearn fit()?

aoifecahill commented 3 years ago

yes :)

desilinguist commented 3 years ago

Should be easy enough.

ghost commented 3 years ago

how different is this from this issue? https://github.com/EducationalTestingService/skll/issues/182?_pjax=%23js-repo-pjax-container

I have a branch half done about the instance weight but never got priority for a long time.

aoifecahill commented 3 years ago

It's the same, I searched for that issue because I knew you had worked on it before, but somehow couldn't find it 🤦‍♀️

desilinguist commented 3 years ago

So, shall we close this issue @aoifecahill ?

aoifecahill commented 3 years ago

Duplicates #182