search

EducationalTestingService / skll

SciKit-Learn Laboratory (SKLL) makes it easy to run machine learning experiments.
http://skll.readthedocs.org
Other
551 stars 67 forks source link

Runs flynt on the code-base and adds flynt a pre-commit check #696

Closed srhrshr closed 2 years ago

srhrshr commented 3 years ago

@desilinguist ,

This PR addresses #695. There weren't many changes that resulted as a result of running flynt on the codebase.

I didn't see pre-commit in the requirements.txt - let me know if this is a dev environment requirement which is tracked outside of requirements and I'll remove it.

Thanks!

desilinguist commented 2 years ago

@srhrshr I am going to add you as a collaborator since Gitlab CI builds do not build for forks. Would you mind re-submitting this PR directly in this repo?

srhrshr commented 2 years ago

@srhrshr I am going to add you as a collaborator since Gitlab CI builds do not build for forks. Would you mind re-submitting this PR directly in this repo?

I've raised a new PR at #697 after addressing your comment. And I'm closing this PR - if there's a way for you to decline this PR instead - please feel free to do that instead.

Thanks!