EducationalTestingService / skll

SciKit-Learn Laboratory (SKLL) makes it easy to run machine learning experiments.
http://skll.readthedocs.org
Other
550 stars 69 forks source link

Upgrade scikit-learn to v1.0.1 #702

Closed desilinguist closed 2 years ago

desilinguist commented 2 years ago

This PR closes #699.

This change is pretty straightforward but it’s definitely backwards incompatible which we will reflect in the release version when we put together the release.

The change specifically motivated by the upgrade are:

Other changes include:

codecov[bot] commented 2 years ago

Codecov Report

Merging #702 (afad8de) into main (4ead823) will increase coverage by 0.03%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #702      +/-   ##
==========================================
+ Coverage   96.85%   96.89%   +0.03%     
==========================================
  Files          63       63              
  Lines        9098     9197      +99     
==========================================
+ Hits         8812     8911      +99     
  Misses        286      286              
Impacted Files Coverage Δ
tests/test_preprocessing.py 100.00% <ø> (ø)
skll/data/writers.py 94.17% <100.00%> (+0.06%) :arrow_up:
skll/learner/__init__.py 97.13% <100.00%> (+0.04%) :arrow_up:
skll/learner/utils.py 94.62% <100.00%> (+0.03%) :arrow_up:
tests/test_commandline_utils.py 99.66% <100.00%> (+<0.01%) :arrow_up:
tests/test_featureset.py 99.78% <100.00%> (+<0.01%) :arrow_up:
tests/test_regression.py 99.64% <100.00%> (+<0.01%) :arrow_up:
tests/test_cv.py 100.00% <0.00%> (ø)
tests/test_output.py 100.00% <0.00%> (ø)
tests/test_classification.py 100.00% <0.00%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4ead823...afad8de. Read the comment docs.

mulhod commented 2 years ago

Should the scikit-learn version also be updated in the Conda recipe? It is currently >=0.24.1,<=0.24.2. Would this version include 1.0, e.g. >=1.0,<=1.0.1?

desilinguist commented 2 years ago

Should the scikit-learn version also be updated in the Conda recipe? It is currently >=0.24.1,<=0.24.2. Would this version include 1.0, e.g. >=1.0,<=1.0.1?

Good catch! I will modify it to be the same as the requirements files.