EducationalTestingService / skll

SciKit-Learn Laboratory (SKLL) makes it easy to run machine learning experiments.
http://skll.readthedocs.org
Other
550 stars 69 forks source link

Fix `—drop_blanks` for `filter_features` command line script #703

Closed desilinguist closed 2 years ago

desilinguist commented 2 years ago

This PR closes #693.

codecov[bot] commented 2 years ago

Codecov Report

Merging #703 (3a697b6) into main (a5d5b3f) will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #703   +/-   ##
=======================================
  Coverage   96.89%   96.89%           
=======================================
  Files          63       63           
  Lines        9197     9213   +16     
=======================================
+ Hits         8911     8927   +16     
  Misses        286      286           
Impacted Files Coverage Δ
skll/utils/commandline/filter_features.py 98.48% <ø> (ø)
skll/data/readers.py 90.26% <100.00%> (+0.06%) :arrow_up:
tests/test_commandline_utils.py 99.67% <100.00%> (+<0.01%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a5d5b3f...3a697b6. Read the comment docs.

desilinguist commented 2 years ago

The code coverage issue can be ignored.