EducationalTestingService / skll

SciKit-Learn Laboratory (SKLL) makes it easy to run machine learning experiments.
http://skll.readthedocs.org
Other
550 stars 69 forks source link

Rename `pos_label_str` to `pos_label` everywhere. #706

Closed desilinguist closed 2 years ago

desilinguist commented 2 years ago

This PR closes #569.

We are only doing part of the issue here (the renaming) but not moving the pos_label field into the Input section from the Tuning section where it currently lives. This is mainly to minimize the amount of changes that someone would need to go through when converting their old code/config files (renaming can be automated).

codecov[bot] commented 2 years ago

Codecov Report

Merging #706 (0dd622f) into main (47175c8) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #706   +/-   ##
=======================================
  Coverage   96.89%   96.89%           
=======================================
  Files          63       63           
  Lines        9199     9199           
=======================================
  Hits         8913     8913           
  Misses        286      286           
Impacted Files Coverage Δ
skll/learner/voting.py 98.45% <ø> (ø)
tests/test_preprocessing.py 100.00% <ø> (ø)
tests/test_voting_learners_expts_1.py 98.38% <ø> (ø)
tests/test_voting_learners_expts_2.py 98.82% <ø> (ø)
tests/test_voting_learners_expts_3.py 98.82% <ø> (ø)
tests/test_voting_learners_expts_4.py 98.76% <ø> (ø)
tests/test_voting_learners_expts_5.py 98.48% <ø> (ø)
skll/config/__init__.py 95.13% <100.00%> (ø)
skll/experiments/__init__.py 95.14% <100.00%> (ø)
skll/learner/__init__.py 97.13% <100.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 47175c8...0dd622f. Read the comment docs.