EducationalTestingService / skll

SciKit-Learn Laboratory (SKLL) makes it easy to run machine learning experiments.
http://skll.readthedocs.org
Other
550 stars 69 forks source link

Added a utility method to the Learner class returning feature names #715

Closed remo-help closed 1 year ago

remo-help commented 2 years ago

This PR adds a simple utility method to the Learner class, allowing it to return the feature names used at the estimator step as a 1-D array. Learners with a selector potentially have a smaller feature name list than is stored in the feature_vectorizer. This method allows for easy access of the actual feature names of features used, even if the selector has removed specific features.

remo-help commented 2 years ago

hold off on review while I add tests

codecov[bot] commented 2 years ago

Codecov Report

Base: 96.90% // Head: 96.90% // No change to project coverage :thumbsup:

Coverage data is based on head (bdf6107) compared to base (bdf6107). Patch has no changes to coverable lines.

:exclamation: Current head bdf6107 differs from pull request most recent head f3d5658. Consider uploading reports for the commit f3d5658 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #715 +/- ## ======================================= Coverage 96.90% 96.90% ======================================= Files 63 63 Lines 9271 9271 ======================================= Hits 8984 8984 Misses 287 287 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=EducationalTestingService). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=EducationalTestingService)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.