EducationalTestingService / skll

SciKit-Learn Laboratory (SKLL) makes it easy to run machine learning experiments.
http://skll.readthedocs.org
Other
551 stars 67 forks source link

Changes for scikit-learn and seaborn upgrades #716

Closed desilinguist closed 2 years ago

desilinguist commented 2 years ago

The following changes were made in order to upgrade scikit-learn to v1.1.2 and seaborn to 0.12.0 (which was released today and is unpinned)

codecov[bot] commented 2 years ago

Codecov Report

Base: 96.90% // Head: 96.90% // Increases project coverage by +0.00% :tada:

Coverage data is based on head (0b3ca9b) compared to base (1502fe8). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #716 +/- ## ======================================= Coverage 96.90% 96.90% ======================================= Files 63 63 Lines 9263 9271 +8 ======================================= + Hits 8976 8984 +8 Misses 287 287 ``` | [Impacted Files](https://codecov.io/gh/EducationalTestingService/skll/pull/716?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=EducationalTestingService) | Coverage Δ | | |---|---|---| | [skll/utils/constants.py](https://codecov.io/gh/EducationalTestingService/skll/pull/716/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=EducationalTestingService#diff-c2tsbC91dGlscy9jb25zdGFudHMucHk=) | `100.00% <ø> (ø)` | | | [skll/\_\_init\_\_.py](https://codecov.io/gh/EducationalTestingService/skll/pull/716/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=EducationalTestingService#diff-c2tsbC9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (ø)` | | | [skll/experiments/\_\_init\_\_.py](https://codecov.io/gh/EducationalTestingService/skll/pull/716/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=EducationalTestingService#diff-c2tsbC9leHBlcmltZW50cy9fX2luaXRfXy5weQ==) | `94.63% <100.00%> (ø)` | | | [skll/experiments/output.py](https://codecov.io/gh/EducationalTestingService/skll/pull/716/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=EducationalTestingService#diff-c2tsbC9leHBlcmltZW50cy9vdXRwdXQucHk=) | `97.38% <100.00%> (+0.01%)` | :arrow_up: | | [skll/learner/\_\_init\_\_.py](https://codecov.io/gh/EducationalTestingService/skll/pull/716/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=EducationalTestingService#diff-c2tsbC9sZWFybmVyL19faW5pdF9fLnB5) | `97.15% <100.00%> (+0.02%)` | :arrow_up: | | [skll/metrics.py](https://codecov.io/gh/EducationalTestingService/skll/pull/716/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=EducationalTestingService#diff-c2tsbC9tZXRyaWNzLnB5) | `97.89% <100.00%> (+0.02%)` | :arrow_up: | | [tests/test\_commandline\_utils.py](https://codecov.io/gh/EducationalTestingService/skll/pull/716/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=EducationalTestingService#diff-dGVzdHMvdGVzdF9jb21tYW5kbGluZV91dGlscy5weQ==) | `99.67% <100.00%> (ø)` | | | [tests/test\_custom\_metrics.py](https://codecov.io/gh/EducationalTestingService/skll/pull/716/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=EducationalTestingService#diff-dGVzdHMvdGVzdF9jdXN0b21fbWV0cmljcy5weQ==) | `100.00% <100.00%> (ø)` | | | [tests/test\_featureset.py](https://codecov.io/gh/EducationalTestingService/skll/pull/716/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=EducationalTestingService#diff-dGVzdHMvdGVzdF9mZWF0dXJlc2V0LnB5) | `99.78% <100.00%> (ø)` | | | [tests/test\_regression.py](https://codecov.io/gh/EducationalTestingService/skll/pull/716/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=EducationalTestingService#diff-dGVzdHMvdGVzdF9yZWdyZXNzaW9uLnB5) | `99.64% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=EducationalTestingService). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=EducationalTestingService)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

desilinguist commented 2 years ago

Github is being dumb and still displaying an old codecov result. There's no issue with coverage and indicated by codecov's comment on the PR.