EducationalTestingService / skll

SciKit-Learn Laboratory (SKLL) makes it easy to run machine learning experiments.
http://skll.readthedocs.org
Other
552 stars 67 forks source link

Add type hints to `skll.learner` module + other refactoring #734

Closed desilinguist closed 1 year ago

desilinguist commented 1 year ago

This PR is part of #561.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 97.80% and project coverage change: -0.06 :warning:

Comparison is base (f8c3da8) 95.26% compared to head (d407d26) 95.20%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #734 +/- ## ========================================== - Coverage 95.26% 95.20% -0.06% ========================================== Files 29 29 Lines 3461 3504 +43 ========================================== + Hits 3297 3336 +39 - Misses 164 168 +4 ``` | [Impacted Files](https://app.codecov.io/gh/EducationalTestingService/skll/pull/734?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=EducationalTestingService) | Coverage Δ | | |---|---|---| | [skll/types.py](https://app.codecov.io/gh/EducationalTestingService/skll/pull/734?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=EducationalTestingService#diff-c2tsbC90eXBlcy5weQ==) | `92.30% <84.61%> (-7.70%)` | :arrow_down: | | [skll/learner/utils.py](https://app.codecov.io/gh/EducationalTestingService/skll/pull/734?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=EducationalTestingService#diff-c2tsbC9sZWFybmVyL3V0aWxzLnB5) | `93.31% <96.49%> (-0.42%)` | :arrow_down: | | [skll/learner/\_\_init\_\_.py](https://app.codecov.io/gh/EducationalTestingService/skll/pull/734?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=EducationalTestingService#diff-c2tsbC9sZWFybmVyL19faW5pdF9fLnB5) | `97.18% <98.85%> (+0.03%)` | :arrow_up: | | [skll/experiments/\_\_init\_\_.py](https://app.codecov.io/gh/EducationalTestingService/skll/pull/734?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=EducationalTestingService#diff-c2tsbC9leHBlcmltZW50cy9fX2luaXRfXy5weQ==) | `94.68% <100.00%> (+0.04%)` | :arrow_up: | | [skll/experiments/utils.py](https://app.codecov.io/gh/EducationalTestingService/skll/pull/734?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=EducationalTestingService#diff-c2tsbC9leHBlcmltZW50cy91dGlscy5weQ==) | `93.38% <100.00%> (ø)` | | | [skll/learner/voting.py](https://app.codecov.io/gh/EducationalTestingService/skll/pull/734?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=EducationalTestingService#diff-c2tsbC9sZWFybmVyL3ZvdGluZy5weQ==) | `98.54% <100.00%> (+0.09%)` | :arrow_up: | | [skll/utils/constants.py](https://app.codecov.io/gh/EducationalTestingService/skll/pull/734?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=EducationalTestingService#diff-c2tsbC91dGlscy9jb25zdGFudHMucHk=) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.