EducationalTestingService / skll

SciKit-Learn Laboratory (SKLL) makes it easy to run machine learning experiments.
http://skll.readthedocs.org
Other
550 stars 69 forks source link

Infrastructure for logging to wandb #758

Closed tamarl08 closed 7 months ago

tamarl08 commented 8 months ago

This PR adds initial infrastructure for W&B logging, including a configuration field to enable W&B, a wand interface class, documentation and tests.

pep8speaks commented 8 months ago

Hello @tamarl08! Thanks for updating this PR.

Line 1852:101: E501 line too long (105 > 100 characters) Line 1859:101: E501 line too long (104 > 100 characters)

Comment last updated at 2023-12-08 16:02:50 UTC
codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (8ac783c) 95.30% compared to head (78541a1) 95.33%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #758 +/- ## ========================================== + Coverage 95.30% 95.33% +0.02% ========================================== Files 29 30 +1 Lines 3580 3598 +18 ========================================== + Hits 3412 3430 +18 Misses 168 168 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tamarl08 commented 8 months ago

Is there a reason the coverage checks are not being met?

I added a test for run_configuration with W&B and now it's covered. I don't know why it did not count as covered before, those lines are tested at test_wandb.py