search

EdupageAPI / edupage-api

A python library for accessing your Edupage account
https://edupageapi.github.io/edupage-api/
GNU General Public License v3.0
66 stars 13 forks source link

[Bug] code is >python3.9, but pip still downloads non-functional version for 3.8 #41

Closed Chaos99 closed 2 years ago

Chaos99 commented 2 years ago

Describe the bug With Python 3.8, pip will download a version of this library that is not up to date and non-functional

Expected behavior If you no longer support 3.8 (I assume so, as you current version is >3.9), remove the pip package for 3.8 and older. Maybe place a note in your readme about the minimum Python version.

ivanhrabcak commented 2 years ago

I thought maybe pip would at least give a warning when you install it:(. Thank you for reminding me! I've added a warning to the readme.

The python version is already on multiple places, but somehow nothings stops you from installing the package on lower python versions.

image

I will also add a check for your python version to setup.py, so the package cannot be installed on older python versions.