search

Edvinas01 / meme-grid

A grid for memes
MIT License
9 stars 9 forks source link

Add pagination #22

Closed arjank closed 5 years ago

arjank commented 5 years ago

Add support for pagination and uses that in the browser. Prevents flooding of the server by not sending new requests when the previous one has not been completed. Also stops listening to scroll events completely when the last item has been received.

Edvinas01 commented 5 years ago

@arjank thank you for contributing! Its working quite nice and the solution is quite simple and elegant.

There is a small issue though. If the first 100 images don't fill the entire screen (that is if the scroll bar is not visible initially), then you won't be able to scroll down and load other pages.

arjank commented 5 years ago

In that case you could consider a smaller monitor and/or larger images ;)

But in all seriousness, I'll look for a solution on that too. It was not something I expected.

arjank commented 5 years ago

I've made sure that you will always have the option to scroll, so you should be able to load more images even if 100 images do not fill your screen.