Closed Edvinas01 closed 5 years ago
Can I try to work on this?
Sure thing!
On Wed, Oct 2, 2019, 14:25 Raffaele Mignone notifications@github.com wrote:
Can I try to work on this?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Edvinas01/meme-grid/issues/28?email_source=notifications&email_token=AB6YT6A4VNVTWBB5YTZQFFLQMSHKPA5CNFSM4I362ZMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAER3UY#issuecomment-537468371, or mute the thread https://github.com/notifications/unsubscribe-auth/AB6YT6FEGMY7BC5HD2EW5KTQMSHKPANCNFSM4I362ZMA .
I sent you a pull request.
Add static code analysis. It should be run after tests - that is after running the
check
task, tests and then static code analysis should run in order.Detekt seems like a good choice: https://github.com/arturbosch/detekt