Edvinas01 / meme-grid

A grid for memes
MIT License
9 stars 9 forks source link

Add static code analysis #28

Closed Edvinas01 closed 5 years ago

Edvinas01 commented 5 years ago

Add static code analysis. It should be run after tests - that is after running the check task, tests and then static code analysis should run in order.

Detekt seems like a good choice: https://github.com/arturbosch/detekt

norangebit commented 5 years ago

Can I try to work on this?

Edvinas01 commented 5 years ago

Sure thing!

On Wed, Oct 2, 2019, 14:25 Raffaele Mignone notifications@github.com wrote:

Can I try to work on this?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Edvinas01/meme-grid/issues/28?email_source=notifications&email_token=AB6YT6A4VNVTWBB5YTZQFFLQMSHKPA5CNFSM4I362ZMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAER3UY#issuecomment-537468371, or mute the thread https://github.com/notifications/unsubscribe-auth/AB6YT6FEGMY7BC5HD2EW5KTQMSHKPANCNFSM4I362ZMA .

norangebit commented 5 years ago

I sent you a pull request.