Edward-Wu / srt-live-server

srt live server for low latency
Other
645 stars 192 forks source link

Added comments from the Directives Wiki into the default configuration file, and fixed a segfault when starting SLS with no config file #59

Closed nebular closed 3 years ago

nebular commented 4 years ago

meant to be 2 separate PRs for your consideration, but forgot to create a branch :(

-------------------------------------------------
           srt-live-srver 
                    v1.4.x 
-------------------------------------------------

2020-09-19 13:58:56:239 SLS INFO: sls_conf_open, parsing conf file='./sls.conf'.
2020-09-19 13:58:56:239 SLS FATAL: open conf file='./sls.conf' failed, please check if the file exist.
2020-09-19 13:58:56:239 SLS INFO: sls_conf_open failed, EXIT!
2020-09-19 13:58:56:239 SLS INFO: exit, stop srt live server...
2020-09-19 13:58:56:239 SLS INFO: exit, release reload_manager_list begin,count=0.
2020-09-19 13:58:56:239 SLS INFO: exit, release reload_manager_list ok.
2020-09-19 13:58:56:239 SLS INFO: exit, release http_stat_client.
2020-09-19 13:58:56:239 SLS INFO: exit, uninit srt .
2020-09-19 13:58:56:239 SLS INFO: exit, close conf.
Segmentation fault

Just checking c != null on closing the config fixes the issue.

nebular commented 3 years ago

blew it again :( I integrated @odensc pull request to fix stats and didn't realise that it would be included here.

nebular commented 3 years ago

closing as my branch is messed out and the PR was very simple !