search

EdwardBerman / shopt

[Astronomical Journal 2024] Efficient PSF Modeling with ShOpt.jl: A PSF Benchmarking Study with JWST NIRCam Imaging
https://edwardberman.github.io/shopt/
MIT License
22 stars 2 forks source link

[JOSS] Missing references #10

Closed aymgal closed 9 months ago

aymgal commented 9 months ago

In the current state of the JOSS paper, I suggest to mention STARRED as another efficient PSF reconstruction technique, as it has been shown to outperform other programs like PSFex (mentioned in the paper) and PSFr (which would need to be mentioned as well), and uses high the just-in-time compiled and auto-diff library JAX.

EdwardBerman commented 9 months ago

This was added in this commit: cda8386704a7f01d270d3b17f8aa200a372b1ae5

aymgal commented 9 months ago

Thanks @EdwardBerman !

STARRED has also been tested on JWST data, see this example notebook. So I would simply remove the mention about the HST data validation, since the PSF modeling assumptions behind the STARRED method are not specific to a given telescope.

In addition, there seems to be a typo "...PSF models with competitive PSFr and PSFex..."

EdwardBerman commented 9 months ago

Ah, you are correct! Thank you @aymgal . I have fixed this with the following commit: c388375

aymgal commented 9 months ago

Thanks for the update, I close this issue!