search

EdwardBetts / osm-wikidata

Match OSM entities with Wikidata items
http://osm.wikidata.link/
GNU General Public License v3.0
107 stars 20 forks source link

buildings should not be matched to institutions #143

Open matkoniecz opened 6 years ago

matkoniecz commented 6 years ago

https://osm.wikidata.link/Q98964 matches institution (National lower house) to building where it resides.

Building should be matched to article about building if it exists (it seems that https://pl.wikipedia.org/wiki/Kompleks_budynk%C3%B3w_Sejmu_Rzeczypospolitej_Polskiej is a likely match or at close to it).

EdwardBetts commented 6 years ago

This match was based on the English language Wikipedia category Lower houses which contains the word houses and causes the software to look for items tagged building or historic=manor. I've adjusted the parameters to exclude categories that contain the phrases lower houses or public houses. See b37bcaa

The item Q98964 includes a headquarters location (P159) property which points to the building. The matcher could look for this property as an indication that a different item should be used for the match. The item page could include a message to the user and a link the headquarters building.

On English Wikipedia Sejm and Sejm and Senate Complex of Poland are both in Category:Legislative buildings in Europe. I think this is wrong, the institution shouldn't be in the building category.

EdwardBetts commented 6 years ago

List of institutions and the buildings that house them.

SELECT ?institution ?institutionLabel ?building ?buildingLabel WHERE {
  ?institution wdt:P159 ?building .
  ?building wdt:P31/wdt:P279* wd:Q41176 .
  ?institution wdt:P31/wdt:P279* wd:Q178706 .
  SERVICE wikibase:label { bd:serviceParam wikibase:language "en" }
}
matkoniecz commented 6 years ago

On English Wikipedia Sejm and Sejm and Senate Complex of Poland are both in Category:Legislative buildings in Europe. I think this is wrong, the institution shouldn't be in the building category.

Fixed in https://en.wikipedia.org/w/index.php?title=Sejm&diff=prev&oldid=800084173

matkoniecz commented 6 years ago

On English Wikipedia Sejm and Sejm and Senate Complex of Poland are both in Category:Legislative buildings in Europe.

Is it what caused the problem? In that case I think it is OK to close this.