search

EdwardBetts / osm-wikidata

Match OSM entities with Wikidata items
http://osm.wikidata.link/
GNU General Public License v3.0
105 stars 20 forks source link

users may be confused why fitting object is not matching - mention requirement for matching names #150

Open matkoniecz opened 6 years ago

matkoniecz commented 6 years ago

https://osm.wikidata.link/Q11721219 and https://osm.wikidata.link/Q1013422 failed to match despite nearby matching objects present (or maybe I missed some necessary criteria)

https://osm.wikidata.link/Q11721219 should match to https://www.openstreetmap.org/node/4002924424#map=19/50.21911/19.79613 and https://www.openstreetmap.org/node/4002924432

https://osm.wikidata.link/Q1013422 should match to https://www.openstreetmap.org/way/120331996#map=19/50.21193/19.83071

EdwardBetts commented 6 years ago

Q11721219 is named "Jaskinia Koziarnia", node 4002924432 is named "Sadlana". The names are different.

The only name on way 120331996 is "Ruiny zamku kazimierzowskiego w Ojcowie", Q1013422 doesn't have this name.

matkoniecz commented 6 years ago

So both name and tags must match? And lack of match indicates that either Wikidata or Wikipedia lacks names?

OK, adding missing name tags is also useful.

EdwardBetts commented 6 years ago

Exactly.

matkoniecz commented 6 years ago

Hmm, maybe it would be useful to mention it on no_match page so people will know how it may be improved?

Items may not match as result of missing data about names in OpenStreetMap and Wikidata. This may be fixed by adding missing names in OSM (name, alt_name, short_name, loc_name, official_name tags may be used) and labels on WIkidata and refreshing cache.

or something like that on top of no match list

EdwardBetts commented 6 years ago

Yes, I should add some text to explain. The item detail page might also list nearby items where the tag matches but the name doesn't match.