search

EdwardChamberlain / IPMI-Fan-Controller

A simple WebGUI Fan controller for IPMI
18 stars 6 forks source link

Development #11

Open BigWebstas opened 1 year ago

BigWebstas commented 1 year ago

Added changes to update fan speed via URL EX - http://xx.xx.xx.xx/set_fan_speeds?percent=95 Defaults to 99 if not specified

EdwardChamberlain commented 1 year ago

This looks great! Thanks for putting it together.

My only concern with your implementation is the security aspect - with how you have it set anyone on the LAN will be able to control the servers fan speed which seems like a risk (especially as manual fan speed will not ramp up if the server begins to overheat).

It would be nice to introduce two controls - first an environment arg that enables this feature and second an "api key" style secret that needs to be passed with the request for authentication.