EdwardPiwowar / BBA

1 stars 0 forks source link

Bridge Composer Issue #942

Open ADavidBailey opened 1 week ago

ADavidBailey commented 1 week ago

@Rick-Wilson uses Bridge Composer filters to screen some of the files in my bba folder which contains BBA archive files. Bridge Composer separates the board id (I'm not sure what to call it) from the [Board...]. I know this is a special use-case and it's not likely to be a common problem. Please consider changing the format so Bridge Composer will leave it alone.

Thanks.

Forwarding a response From Rick Wilson...

I think this is because, as comments, these rows are not associated with the individual hands. I think Bridge Composer writes all comment rows at the top. I think BBA would be better off including these values as custom tags in the hands. E.g., instead of:

[Event ""] [Site ""] [Date "2024.10.02"] [Board "1"] % 00C90AA49D848400ECBFC9EC7F1C [North "EPBot1"] [East "EPBot2"]

Use:

[Event ""] [Site ""] [Date "2024.10.02"] [Board "1"] [BBA-Index 00C90AA49D848400ECBFC9EC7F1C] [North "EPBot1"] [East "EPBot2"]

On Tue, Oct 15, 2024 at 4:58 AM David Bailey [adavidbailey@gmail.com](mailto:adavidbailey@gmail.com) wrote: Why are all of the 'correct number 1-256' (that's how BBA refers to them) separated from the pbn '[Deal...' statements?

Screenshot 2024-10-15 at 6.53.31 AM.png

Rick-Wilson commented 1 week ago

Correction - tags need to be quoted. Should look like

[Event ""] [Site ""] [Date "2024.10.02"] [Board "1"] [BBA_Index "00C90AA49D848400ECBFC9EC7F1C"] [North "EPBot1"] [East "EPBot2"]

ADavidBailey commented 1 week ago

After thinking about this, I think we need to recalculate that number. What's the formula?

ThorvaldAagaard commented 1 week ago

If you use {} the information is related to the board [Event ""] [Site ""] [Date "2024.10.02"] [Board "1"] { 00C90AA49D848400ECBFC9EC7F1C} [North "EPBot1"] [East "EPBot2"]

{xxx} is handled as comments in bridge composer, and can be placed so it is printed together with that section, like , play, auction, deal, board etc And will be presented in Composer and kept, when saving

[BBA_Index "00C90AA49D848400ECBFC9EC7F1C"] is fine but might cause problem for other pbn-readers

ADavidBailey commented 1 week ago

This mornin' I woke up thinkin...

I already have a program that comment's my Dealer statistics. That can surround the board-id with curley braces, like this,{00C90AA49D848400ECBFC9EC7F1C} as Thorvald suggested.

But, that program runs on files in my pbn files. We need to do that with files in my bba folder (BBA archives). @Rick-Wilson can your filter.js do that? If not, I could write a separate one to run against bba files.

@Rick-Wilson you might write a regular expression to change all of the % board ids to {board ids} to verify that Bridge Composer works with them nicely.

EdwardPiwowar commented 1 week ago

It seems to work (on top). Thorvald, should I put {00A4F981D937E8762A2574FDC347} instead of % ? image

ADavidBailey commented 1 week ago

If you look at one of the bba-filtered files (the output of Bridge Composer) in an editor, you see all of the % comments at the top. Like this:

% 1-2 - Two suit takeout double % 1-2 - Two way game tries % 1-2 - Two Way New Minor Forcing % 1-2 - Unusual 1NT % 1-2 - Unusual 2NT % 1-2 - Unusual 4NT % 1-2 - Weak natural 2D % 1-2 - Weak natural 2M % % 0895E07A86887E7AED098AA6FA00 % 0AA67383E55023C3C1988B466E7B % 098A8D71205F80D89174E2C1DAC6 % 0BB2A5BF5B1C1BE7E3312A2ABB5A % 0A958CF1CB60824F695EEDBC7EC6 % 09A7A635FB5E1737A81FBDDE2DC3 % 0BE9B42471FE220911943694467D % 086D979D37F05D0313663237C3EC % 09AA547834DCE3105D2C92932121 % 0BE62C9ED9FD1F26D9B5367617DA

ThorvaldAagaard commented 1 week ago

Yes use {}