EdwardRaff / JSAT

Java Statistical Analysis Tool, a Java library for Machine Learning
GNU General Public License v3.0
789 stars 205 forks source link

NullPointer getting thrown when using BDS feature selector on ClassificationDataSet #94

Closed jbax7635 closed 3 years ago

jbax7635 commented 3 years ago

Either i'm not using correctly or when using the BDS selector i keep getting a null pointer

i'm using the selector like this:

Classifier classifier = new LogisticRegression();

DataTransform SFS = new BDS(20, classificationDataSet, classifier , 10 ); // error gets thrown here classificationDataSet.applyTransform(SFS);

stack trace shows:

java.lang.NullPointerException at jsat.classifiers.ClassificationDataSet.addDataPoint(ClassificationDataSet.java:342) at jsat.classifiers.ClassificationDataSet.getSubset(ClassificationDataSet.java:234) at jsat.classifiers.ClassificationDataSet.getSubset(ClassificationDataSet.java:20) at jsat.DataSet.randomSplit(DataSet.java:488) at jsat.DataSet.cvSet(DataSet.java:513) at jsat.classifiers.ClassificationModelEvaluation.evaluateCrossValidation(ClassificationModelEvaluation.java:176) at jsat.datatransform.featureselection.SFS.getScore(SFS.java:315) at jsat.datatransform.featureselection.SFS.SFSSelectFeature(SFS.java:272) at jsat.datatransform.featureselection.BDS.search(BDS.java:195) at jsat.datatransform.featureselection.BDS.(BDS.java:83) at backTester.BackTester.transform(BackTester.java:794) at backTester.BackTester.getEventModel(BackTester.java:676) at backTester.BackTester.runBackTest(BackTester.java:147) at backTester.BackTester.main(BackTester.java:72)

any help would be greatly appreciated

jbax7635 commented 3 years ago

I've just forked the git repo hoping to fix the issue and found the issue doesn't exist in the current git version.

Does the maven version need updating?

EdwardRaff commented 3 years ago

Yea, use the head version via jitpack. I’ve got to deal with my old maven private key being on an almost dead computer…

On Jan 13, 2021, at 8:47 PM, John Baxter-Lindsay notifications@github.com wrote:

I've just forked the git repo hoping to fix the issue and found the issue doesn't exist in the current git version.

Does the maven version need updating?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/EdwardRaff/JSAT/issues/94#issuecomment-759870138, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAPKNUURUOHNDJC35JE2NNLSZZEJRANCNFSM4WBRWBYA.

jbax7635 commented 3 years ago

Thanks Edward!!