search

EdwardSmith1884 / GEOMetrics

Repo for the paper "GEOMetrics: Exploiting Geometric Structure for Graph-Encoded Objects"
MIT License
117 stars 12 forks source link

A bug about loss function #12

Closed Zhangsihao-Yang closed 4 years ago

Zhangsihao-Yang commented 4 years ago

Check the line below: https://github.com/EdwardSmith1884/GEOMetrics/blob/09471d70f441482319543bb5214eaaab38f64507/GEOMetrics.py#L139 07/GEOMetrics.py#L139 Should it be: total_loss += surface_loss

EdwardSmith1884 commented 4 years ago

It can be either I guess depending on what you want to log