search

Edwin1022 / pe

0 stars 0 forks source link

Failed input validation for email address #4

Open Edwin1022 opened 1 week ago

Edwin1022 commented 1 week ago

Summary

Expected Behavior: While trying to add a contact with invalid email address format (such as johnd@com), the contact should not be added and the user should be prompted an error message saying that the contact that the user trying to add is with an invalid email address.

Actual Behavior: While trying to add a contact with invalid email address format, the contact is added and the user is prompted a success message.

Steps to Reproduce

  1. run command student n/John Doe id/A0123456X p/98765432 e/johnd@com a/311, Clementi Ave 2, #02-25 t/friends t/owesMoney

Screenshots

image.png

Reasoning for Severity

This can be considered as a low feature flaw as the application fails to validate inputs correctly, meaning the user can give in any email address with invalid format and will not be prompted by the app at all and thus can cause a minor inconvenience for user.

nus-se-script commented 1 week ago

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Incorrect match of behaviour for validation of email input between user guide and in actual product.

image.png

^I am able to add a contact with a email without separating the domain with periods

(command entered: company n/Newgate Prison i/Security e/newgateprison@examplecom a/Newgate Prison p/1234567 t/prison t/facility

But the user guide mentioned that it has to be separated by periods

image.png

[original: nus-cs2103-AY2425S1/pe-interim#205] [original labels: severity.Low type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

No details provided by team.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your reason]

## :question: Issue type Team chose [`type.FunctionalityBug`] Originally [`type.FeatureFlaw`] - [ ] I disagree **Reason for disagreement:** [replace this with your reason]