search

EdwinKipruto / mfp2

3 stars 0 forks source link

Roadmap for release #42

Closed matherealize closed 1 year ago

matherealize commented 1 year ago

A suggestion for a roadmap of things to do before release of version 0.2 (CRAN / Github public release).

We should also think about adding a vignette with at least one small example. Could be taken maybe from the mfp package.

EdwinKipruto commented 1 year ago

I started working on the formula interface. I think we should discuss on how the interface should look like. For example, do we need strata and offset to be part of the formula?

On Mon, May 8, 2023, 12:10 PM Michael Kammer @.***> wrote:

A suggestion for a roadmap of things to do before release of version 1.0 (CRAN / Github public release).

We should also think about adding a vignette with at least one small example. Could be taken maybe from the mfp package.

— Reply to this email directly, view it on GitHub https://github.com/EdwinKipruto/mfp2/issues/42, or unsubscribe https://github.com/notifications/unsubscribe-auth/AM233ZHS6LC2JJ4FUQT7W2TXFDA75ANCNFSM6AAAAAAXZXKP4A . You are receiving this because you are subscribed to this thread.Message ID: @.***>

matherealize commented 1 year ago

For further discussion of strata and offsets, see our pull request #40

matherealize commented 1 year ago

I think most of the work to get the code in a shape for release on CRAN is done. I consider #21 not mandatory for release.

If we want to, we can now check out any additional functionality which should be part of the first release.

EdwinKipruto commented 1 year ago

It seems there’s bug somewhere. The new program doesn’t run at the moment. Likely cause of problem is printing option of the verbose. Check your changes @matherealize

On Fri 26. May 2023 at 15:04, Michael Kammer @.***> wrote:

I think most of the work to get the code in a shape for release on CRAN is done. I consider #21 https://github.com/EdwinKipruto/mfp2/issues/21 not mandatory for release.

If we want to, we can now check out any additional functionality which should be part of the first release.

— Reply to this email directly, view it on GitHub https://github.com/EdwinKipruto/mfp2/issues/42#issuecomment-1564365045, or unsubscribe https://github.com/notifications/unsubscribe-auth/AM233ZH5YCQZIP35I4DY6MDXICS6NANCNFSM6AAAAAAXZXKP4A . You are receiving this because you commented.Message ID: @.***>

matherealize commented 1 year ago

It seems there’s bug somewhere. The new program doesn’t run at the moment. Likely cause of problem is printing option of the verbose. Check your changes @matherealize … On Fri 26. May 2023 at 15:04, Michael Kammer @.> wrote: I think most of the work to get the code in a shape for release on CRAN is done. I consider #21 <#21> not mandatory for release. If we want to, we can now check out any additional functionality which should be part of the first release. — Reply to this email directly, view it on GitHub <#42 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AM233ZH5YCQZIP35I4DY6MDXICS6NANCNFSM6AAAAAAXZXKP4A . You are receiving this because you commented.Message ID: @.>

With the most recent version, possibly due to your changes, I do not find an error. Do you still encounter a problem or was this resolved already?

EdwinKipruto commented 1 year ago

I corrected the errors

On Tue 30. May 2023 at 15:44, Michael Kammer @.***> wrote:

It seems there’s bug somewhere. The new program doesn’t run at the moment. Likely cause of problem is printing option of the verbose. Check your changes @matherealize https://github.com/matherealize … <#m1540548761488543794> On Fri 26. May 2023 at 15:04, Michael Kammer @.> wrote: I think most of the work to get the code in a shape for release on CRAN is done. I consider #21 https://github.com/EdwinKipruto/mfp2/issues/21 <#21 https://github.com/EdwinKipruto/mfp2/issues/21> not mandatory for release. If we want to, we can now check out any additional functionality which should be part of the first release. — Reply to this email directly, view it on GitHub <#42 (comment) https://github.com/EdwinKipruto/mfp2/issues/42#issuecomment-1564365045>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AM233ZH5YCQZIP35I4DY6MDXICS6NANCNFSM6AAAAAAXZXKP4A https://github.com/notifications/unsubscribe-auth/AM233ZH5YCQZIP35I4DY6MDXICS6NANCNFSM6AAAAAAXZXKP4A . You are receiving this because you commented.Message ID: @.>

With the most recent version, possibly due to your changes, I do not find an error. Do you still encounter a problem or was this resolved already?

— Reply to this email directly, view it on GitHub https://github.com/EdwinKipruto/mfp2/issues/42#issuecomment-1568462779, or unsubscribe https://github.com/notifications/unsubscribe-auth/AM233ZCLLCP75FZQI5NZOD3XIX2TTANCNFSM6AAAAAAXZXKP4A . You are receiving this because you commented.Message ID: @.***>

matherealize commented 1 year ago

I have changed this to reflect the current status of the package better. I propose we do not release as version 1.0, but version 0.2. This reflects that there are still several issues with the code and that development is ongoing. (1.0 is usually used for stable releases.)

Of course, this is just versioning semantics, no change in the plan to release!

matherealize commented 1 year ago

I'm closing this for now, the enhancements are available as issues for later versions.