Change from ${version} to ${project.version} in pom files

EdwinLi / powermock

Automatically exported from code.google.com/p/powermock

0 stars 0 forks source link

Change from ${version} to ${project.version} in pom files #287

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

See version dependency in: 
http://mvnrepository.com/artifact/org.powermock/powermock-core/1.4.6

for the reason.

Original issue reported on code.google.com by johan.ha...@gmail.com on 19 Oct 2010 at 11:05

GoogleCodeExporter commented 9 years ago

Original comment by johan.ha...@gmail.com on 10 Apr 2011 at 12:48

Added labels: Milestone-Release1.6
Removed labels: Milestone-Release1.5

GoogleCodeExporter commented 9 years ago

Anybody in need/interested, feel free to use diff file attached.

Original comment by pavel.j....@gmail.com on 18 Jun 2011 at 7:48

Attachments:

pom-project-version.diff

GoogleCodeExporter commented 9 years ago

Thanks. How ever I think we should change to the real version number instead 
(e.g. 1.4.10-SNAPSHOT) because I think there's a bug in the Maven release 
plugin (don't remember the details now though). But thanks a lot for the patch 
anyways, it's always great when people help out.

Original comment by johan.ha...@gmail.com on 22 Jun 2011 at 6:16

GoogleCodeExporter commented 9 years ago

I'm with johan.ha...@gmail.com, please use real versions or better yet a 
powermock.version property to specify the version of module dependencies.

Soooo confusing when a "version" property can mix-up the versions of 
dependencies used by Powermock!

btw. the issue is still there with Powermock 1.4.9!

Original comment by pvdis...@gmail.com on 10 Oct 2011 at 6:11

GoogleCodeExporter commented 9 years ago

Yeah we should probably do that for the next release. Do you think you could 
help us out with this? I'm extremely busy right now can could use all the help 
I can get.

Original comment by johan.ha...@gmail.com on 10 Oct 2011 at 6:35

GoogleCodeExporter commented 9 years ago

Sure, I'll create a diff this evening based on the current trunk

Original comment by pvdis...@gmail.com on 10 Oct 2011 at 6:40

GoogleCodeExporter commented 9 years ago

Thank you so much.

Original comment by johan.ha...@gmail.com on 10 Oct 2011 at 7:41

GoogleCodeExporter commented 9 years ago

Attached the diff based on trunk rev 1712 to change all ${version} in 
${project.version}.
Diff is created with `svn diff`.

Tested the changes with:
    mvn clean install -Dversion=0.0.0

(The -Dversion=0.0.0 is to make sure no ${version} properties were left :))

Hope you can work with this.

Original comment by pvdis...@tricode.nl on 10 Oct 2011 at 8:13

Attachments:

project.version.svn.diff

GoogleCodeExporter commented 9 years ago

I've applied the patch and committed it to trunk. Thank you very much for your 
help. I'll close the issue.

Original comment by johan.ha...@gmail.com on 11 Oct 2011 at 6:33

Changed state: Fixed