search

EdwinMindcraft / ArsMagica2

Ars Magica 2 Bug Tracker
13 stars 9 forks source link

Fixed some bugs, and translated japanese #23

Closed ghost closed 6 years ago

ghost commented 6 years ago

Hi, I am fun of ArsMagica mod. My English is not good enough, sorry.

I found some bugs then fixed, and translated texts to japanese. At first, I made two branches. Fixing bugs branch, and translation branch. But two branches conflict in some cases, I merged these branches to one. Most important bug, power nodes often lost path. This problem can be looked on function addTileEntity() of 'net.minecraft.world.chunk.Chunk'. PowerNode is registered when call setWorkObj(), but setPos() is called after it. Registered PowerNode keeped origin position. I fixed to re-register PowerNode by overrided setPos(). Other bugs are bit. Please merge these modifications, if it doesn't have problem.

Thank you.

EdwinMindcraft commented 6 years ago

I'd recommend you recreate the pull request over at Growlith1223/ArsMagica2. I'm not exactly active right now and that's the version that receives updates.

ghost commented 6 years ago

Ah, okay. I thought your repository is the latest. thank you.