EdwinMindcraft / ArsMagica2

Ars Magica 2 Bug Tracker
13 stars 9 forks source link

Swiftswim not working #45

Open tanisdlj opened 6 years ago

tanisdlj commented 6 years ago

The spell casts but I can't see any variation in the swimming speed at all.

Mishin870 commented 6 years ago

Do you have 1 water essence in your inventory? upd: i see that spell doesn't consume it. I will debug this, but can't promise anything, because I'm not familiar with 1.10.2

tanisdlj commented 6 years ago

Thanks! I didn't know you needed reagents. Let me know if I can help you somehow.

Mishin870 commented 6 years ago

The potion works only on the server side, and the player's speed on it is 0. I think that I can solve it with PlayerTickEvent, but I'm trying to find a more elegant solution

Mishin870 commented 6 years ago

@tanisdlj you can help me if you launch am2 on 1.7.10 and say me, what swift swim do with player speed. i.e. in my fix, player can get infinite speed in water, because there is no speed limit

tanisdlj commented 6 years ago

Just in case I am running AM2 on 1.10.2

Mishin870 commented 6 years ago

OK. I will test this spell under 1.7.10 in 2-3 days. I just broke Java using DCEVM (this is a tool that can reload code into game in runtime in addition to standart java hotswap, and this is good, but now I can't launch 1.7.10)

Mishin870 commented 6 years ago

Wow! This spell.. does not do anything when running on 1.7.10 (from curseforge. maybe I'm doing something wrong). And I can't find any information about his characteristics. I can assume that swift swim must give the same speed of movement as on land, but original 1.10.2 code says, that (I assume) this will speed up player without any speed limit Then.. I will make this limit upd: I made this in the last commit of #46