EdwinMindcraft / origins-architectury

MIT License
20 stars 17 forks source link

After March 15th update getting Crashes related to "java.lang.NullPointerException: Cannot invoke "net.minecraft.resources.ResourceLocation.equals(Object)" because "this.lootTableId" is null" #428

Closed Darkmega18 closed 6 months ago

Darkmega18 commented 7 months ago

I think something you (MerchantPug) rewrote in a recent version (1.7.1.4) after a different issue report isn't sitting well with a bunch of other stuff on 1.19.2 that I'm using. So it might've been a step back in some regards unforseen.

I'm getting so many crashes related to Mana and Artifice and eventually a veinmining moment (the topafter I removed it all related to: "java.lang.NullPointerException: Cannot invoke "net.minecraft.resources.ResourceLocation.equals(Object)" because "this.lootTableId" is null" It seems to occur whenever mobs fight one another with MnA due to it's faction mobs having little fights off screen. The Ore excavation issue also hit me with a crash related to the same kind of error. I only found out it was related to apoli eventually due to searching through debug logs and eventually installing "not enough crashes" which seems to be wise to the mod and where the crash ACTUALLY comes from.

Heres some example crashes I've had over the last couple days. Currently, I'm using origins only to implement my "deaths door" mechanic into a recent testing pack (which you might recall from some of my other issues that had been troubleshooted). But otherwise everyones origin is defaulted to human.

Mana and artifice and one Mii Alliance related call somewhere in there, I forget which one. crash-2024-03-17_13.05.39-server.txt crash-2024-03-17_12.45.10-server.txt crash-2024-03-15_19.38.13-server.txt crash-2024-03-15_15.33.45-server.txt crash-2024-03-15_15.29.55-server.txt crash-2024-03-15_15.20.40-server.txt

ore excav related loot call after installing not enough crashes. crash-2024-03-17_13.21.46-server.txt

Theres also a crash that someone else posted before me on this issue here we both went to after our initial run ins with the bug due to what the stack traces pointed to.

I can confirm they also have the most recent 1.19.2 origins version installed after reading their crash report to grab the modlist. https://github.com/Mithion/Mana-And-Artifice/issues/730

I had smooth sailing before this update, so... I guess I'll do what I always do and backdate for a bit until you lemme know it should be good? Thanks.

MerchantPug commented 7 months ago

Ah, this is the same issue as #425. Will fix eventually.

Darkmega18 commented 7 months ago

guess it's something you need to backport? the linked issue seems fixed already?

MerchantPug commented 7 months ago

yeah

MerchantPug commented 6 months ago

Brought over the fix from 1.20.1, fixed!

Darkmega18 commented 6 months ago

oh! spicy. thanks pug.