EdwinMindcraft / origins-architectury

MIT License
20 stars 17 forks source link

add_velocity not moving in proper direction on local space Z-axis #452

Open thespookyfish opened 2 months ago

thespookyfish commented 2 months ago

I've encountered a bug with add_velocity where it's not reading Z-axis direction in the local space correctly. If I'm facing any of the directions on the chart below that are blue (so cardinal directions, and the intercardinals) then I move in the expected direction.

But If I'm in any of the red zones, then I'm noticing that I'm not moving in the direction of my crosshair, but more to one side, with the amount varying with how far off one of the blue zones I am. I've noticed that this strange offset always seems biased towards the intercardinals.

Initially I thought I must be doing something wrong, and so reached out for help on the Origins Discord, but after a lot more testing, I'm thinking this is probably a bug of some kind?

This is the code I was using, and the only mods in the instance were Origins, Caelus API, and Embeddium. And I even tried without Embeddium active. NeoForge 1.20.1

{
    "name": "Leap",
    "description": "placeholder",
    "type": "origins:active_self",
    "entity_action": {
        "type": "origins:and",
        "actions": [
            {
                "type": "origins:add_velocity",
                "z": 10,
                "space": "local",
                "client": true,
                "server": true
            }
        ]
    },
    "key": "secondary"
}
thespookyfish commented 2 months ago

add_velocity_bug

thespookyfish commented 2 months ago

I realize add_velocity in my code is nested in an unnecessary "origins:and." I was looking for a way to add some exhaustion to the power and was testing that. I just retested without the nesting, and got identical results.