search

EdwinTh / padr

Padding of missing records in time series
https://edwinth.github.io/padr/
Other
132 stars 12 forks source link

.dots deprecated #80

Closed MattCowgill closed 3 years ago

MattCowgill commented 3 years ago

padr:::set_to_original_type() invokes dplyr::group_by() and calls the .dots argument of group_by(). That argument was deprecated in dplyr 1.0.0. Using padr::pad() now throws up a warning message about this deprecation.

The relevant line: https://github.com/EdwinTh/padr/blob/26cfba907d5c8ff5536862e5a55643dc8fd1e818/R/thicken.R#L148

EdwinTh commented 3 years ago

Thanks for spotting this. Will fix it

kgjerde commented 3 years ago

Sorry about the unintended noise. That commit does not fix the issue. However, to change the line to

x <- dplyr::group_by(x, dplyr::across(grps))

seems to do the trick (see tidyverse/dplyr#4734). I have not run the test suite, however.

EdwinTh commented 3 years ago

Thanks for looking into it. I must admit it fell of my radar, will look into it soon.

EdwinTh commented 3 years ago

This is now fixed and will be released soon. Thanks for the help!

MattCowgill commented 3 years ago

Thanks for a great package @EdwinTh