Allow no thickening if the "interval" is "too short"

EdwinTh / padr

Padding of missing records in time series

https://edwinth.github.io/padr/

Other

132 stars 12 forks source link

Allow no thickening if the "interval" is "too short" #84

Closed Fuco1 closed 2 years ago

Fuco1 commented 3 years ago

I think this check makes no sense. What if randomly my sales data only happen to be one sale on each 1st day of the month and I'm thickening to a month to perform monthly aggregates. It just crashed my pipeline so it's not just theoretical example :D

https://github.com/EdwinTh/padr/blob/f960e4604346e138d819083d7754f7030d648cfa/R/thicken.R#L128-L131

EdwinTh commented 3 years ago

Thanks for notifying me. I will look into it soon.