search

EdwinTh / padr

Padding of missing records in time series
https://edwinth.github.io/padr/
Other
132 stars 12 forks source link

group #85

Closed youngday2 closed 2 years ago

youngday2 commented 2 years ago

I am getting the following error and seems like its an issue with group. R Error: start value is larger than the end value for all groups.

You can find reproducible example here https://stackoverflow.com/questions/69726957/pad-data-prior-to-start-date-and-after-end-date-in-r

If only one site is evaluated the function works as intendended

thanks

EdwinTh commented 2 years ago

When I run your code, your start_val is "2016-01-01" and your end_val is "2012-12-31", so the error message seems correct to me.

What is it that is unexpected to you?

youngday2 commented 2 years ago

You are correct. However, those dates are associated with different sites, indicating the group = 'site' is not functioning as intended. It could very well be on my end but I cannot see how.

On Fri, Oct 29, 2021 at 1:21 AM Edwin Thoen @.***> wrote:

When I run your code, your start_val is "2016-01-01" and your end_val is "2012-12-31", so the error message seems correct to me.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/EdwinTh/padr/issues/85#issuecomment-954461963, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOYDN7KI6TNZLLANN77JEVTUJJDQBANCNFSM5G5CF5AA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

EdwinTh commented 2 years ago

I see what you want to do now. There is no grouping on these arguments, you can only file a start and an end date for all the groups. If you want to use different start and end values for the groups, then you have to apply that yourself. I believe you did it yourself already in the SO post.

I will update the docs at the next release that there is no grouping on start and end date arguments, to make it clear that this is not working the way you expected it to work. Thanks for filing the issue.

youngday2 commented 2 years ago

Thanks Edwin.

On Fri, Nov 5, 2021 at 8:51 AM Edwin Thoen @.***> wrote:

I see what you want to do now. There is no grouping on these arguments, you can only file a start and an end date for all the groups. If you want to use different start and end values for the groups, then you have to apply that yourself. I believe you did it yourself already in the SO post.

I will update the docs at the next release that there is no grouping on start and end date arguments, to make it clear that this is not working the way you expected it to work. Thanks for filing the issue.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/EdwinTh/padr/issues/85#issuecomment-961910822, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOYDN7O5GV66F7FOICIYDDDUKPONXANCNFSM5G5CF5AA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.